Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update run-e2e-test script to setup cluster #186

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Update run-e2e-test script to setup cluster #186

merged 1 commit into from
Jan 25, 2019

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Jan 23, 2019 •
edited
Loading

Is this a bug fix or adding new feature?
/feature

What is this PR about? / Why do we need it?
Add logics to provision the cluster for prow integration. The changes include:

  • Creating/Delete cluster using kops
  • Building/Pushing Container image to ECR
  • Generate driver manifest for testing using the ECR image
  • Split e2e test into two groups, single-az e2e test and multi-az e2e test

What testing is done?
Tested:

  • make test-e2e-single-az
  • make test-e2e-multi-az

/cc @gyuho @M00nF1sh

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2019
@coveralls
Copy link

coveralls commented Jan 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 376

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.022%
Totals Coverage Status
Change from base Build 375: 0.0%
Covered Lines: 755
Relevant Lines: 1198
💛 - Coveralls

@leakingtapan leakingtapan force-pushed the e2e-shim branch 2 times, most recently from 2992e56 to 181f07d Compare January 23, 2019 21:00
@M00nF1sh
Copy link

M00nF1sh commented Jan 23, 2019 •
edited
Loading

looks pretty good 🚀

/lgtm

@leakingtapan leakingtapan force-pushed the e2e-shim branch 2 times, most recently from 93f3f04 to dba67df Compare January 23, 2019 21:22
@gyuho
Copy link
Member

gyuho commented Jan 23, 2019

looks good!

@leakingtapan leakingtapan force-pushed the e2e-shim branch 3 times, most recently from 4918d27 to a44b58d Compare January 24, 2019 20:37
dkoshkin
dkoshkin reviewed Jan 25, 2019
View reviewed changes
hack/run-e2e-test Outdated Show resolved Hide resolved
@leakingtapan leakingtapan merged commit 9218630 into kubernetes-sigs:master Jan 25, 2019
@leakingtapan leakingtapan deleted the e2e-shim branch January 25, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoshkin dkoshkin dkoshkin left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leakingtapan @k8s-ci-robot @coveralls @M00nF1sh @gyuho @dkoshkin