Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for 'not mounted' in linux Unstage/Unpublish #1597

Merged
merged 1 commit into from
May 15, 2023
Merged

Check for 'not mounted' in linux Unstage/Unpublish #1597

merged 1 commit into from
May 15, 2023

Conversation

ConnorJC3
Copy link
Contributor

Is this a bug fix or adding new feature?

Bug fix

What is this PR about? / Why do we need it?

NodeUnstage/UnpublishVolume should return a success when the path requested has already been unstaged/unpublished.

What testing is done?

Manual/CI

@ConnorJC3
Check for 'not mounted' in linux Unstage/Unpublish
7fe1031 
NodeUnstage/UnpublishVolume should return a success when the path
requested has already been unstaged/unpublished.

Signed-off-by: Connor Catlett <conncatl@amazon.com>
@k8s-ci-robot k8s-ci-robot requested review from hanyuel and torredil May 15, 2023 13:03
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2023
@torredil
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
This was referenced May 15, 2023
Merged
Merged
@k8s-ci-robot
Copy link
Contributor

@ConnorJC3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows 7fe1031 link false /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@torredil
Copy link
Member

/test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

@hanyuel
Copy link
Contributor

hanyuel commented May 15, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 7f79b95 into kubernetes-sigs:master May 15, 2023
@dobsonj dobsonj mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuel hanyuel Awaiting requested review from hanyuel

@torredil torredil Awaiting requested review from torredil

Assignees

@torredil torredil

@hanyuel hanyuel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ConnorJC3 @torredil @k8s-ci-robot @hanyuel