Add support for Fast Snapshot Restores

[torredil]

Is this a bug fix or adding new feature?

• New feature.

What is this PR about? / Why do we need it?

• This PR adds support for Fast Snapshot Restores via the fastSnapshotRestoreAvailabilityZones VolumeSnapshotClass parameter. Availability zones are specified as a comma-separated list.

Example

apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshotClass
metadata:
  name: csi-aws-vsc
driver: ebs.csi.aws.com
deletionPolicy: Delete
parameters:
  fastSnapshotRestoreAvailabilityZones: "us-east-1a, us-east-1b"

• The driver must be given permission to access the EnableFastSnapshotRestores EC2 API. This example snippet can be used in an IAM policy to grant access to EnableFastSnapshotRestores:

{
  "Effect": "Allow",
  "Action": [
    "ec2:EnableFastSnapshotRestores"
  ],
  "Resource": "*"
}

Failure Mode

• The driver will attempt to check if the availability zones provided are supported for fast snapshot restore via DescribeAvailabilityZones before attempting to create the snapshot. If the EnableFastSnapshotRestores API call fails, the driver will hard-fail the request and delete the snapshot. This is to ensure that the snapshot is not left in an inconsistent state.

Issues

• closes Fast Snapshot Restore Support #869.
• closes [Feature] Support initialization of EBS volumes created from Snapshots #1100.

What testing is done?

$ make test

Ran 119 of 119 Specs in 0.418 seconds
SUCCESS! -- 119 Passed | 0 Failed | 0 Pending | 0 Skipped

• manifests

apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshotClass
metadata:
  name: csi-aws-vsc
driver: ebs.csi.aws.com
deletionPolicy: Delete
parameters:
  fastSnapshotRestoreAvailabilityZones: "us-east-1a,us-east-1b,us-east-1c"
---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: ebs-sc
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: ebs-claim
spec:
  accessModes:
    - ReadWriteOnce
  storageClassName: ebs-sc
  resources:
    requests:
      storage: 4Gi
---
apiVersion: v1
kind: Pod
metadata:
  name: app
spec:
  containers:
  - name: app
    image: centos
    command: ["/bin/sh"]
    args: ["-c", "while true; do echo $(date -u) >> /data/out.txt; sleep 5; done"]
    volumeMounts:
    - name: persistent-storage
      mountPath: /data
  volumes:
  - name: persistent-storage
    persistentVolumeClaim:
      claimName: ebs-claim
---
apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshot
metadata:
  name: ebs-volume-snapshot
spec:
  volumeSnapshotClassName: csi-aws-vsc
  source:
    persistentVolumeClaimName: ebs-claim
---

[ConnorJC3]

Largely lgtm, great work 🎉

In addition to the nits below, can we add a test case for the controller when cloud.AvailabilityZones indicates the request is invalid?

[hanyuel]

Overall LGTM. Left a few minor comments

[ConnorJC3]

small mistake on new tests, otherwise lgtm

[ConnorJC3]

/retest

[ConnorJC3]

/lgtm

[ConnorJC3]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ConnorJC3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment