Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eddie Torres torredil@amazon.com
Is this a bug fix or adding new feature?
CSIProxyMounter
- which bridges the gap between the filesystem, disk, volume clients, and the CSI Proxy - is currently implemented as a struct and thus cannot be mocked for testing.What is this PR about? / Why do we need it?
ProxyMounter
interface, implemented by the existingCSIProxyMounter
struct to enable mocks needed for testing with minimal refactoring required.mockgen
to generate a mock of theProxyMounter interface,MockProxyMounter
.What testing is done?