Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update driver dependencies #1208

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

rdpsin
Copy link
Contributor

@rdpsin rdpsin commented Apr 12, 2022

Is this a bug fix or adding new feature?
Update dependencies

What is this PR about? / Why do we need it?
This commit updates the Go AWS SDK to v1.43.37, k8s.io/kubernetes to
v1.21.11 and mount-utils to v0.21.11

Also updated driver/mock_mount.go, driver/sanity_test.go and mounter/safe_mounter_windows.go since mountutils.Interface contains a new
method.

Ran go mod tidy and go mod vendor.

What testing is done?
Unit tests
e2e tests

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rdpsin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot requested review from gnufied and vdhanan April 12, 2022 19:12
@AndyXiangLi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2022
This commit updates the Go AWS SDK to v1.43.37, k8s.io/kubernetes to
v1.21.11 and mount-utils to v0.21.11

Also updated driver/mock_mount.go, driver/sanity_test.go and mounter/safe_mounter_windows.go since mountutils.Interface contains a new
method.

Also, updates the e2e/run.sh to use `go install ginkgo` instead of `go
get ginkgo`.

Ran `go mod tidy` and `go mod vendor`.
@AndyXiangLi
Copy link
Contributor

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyXiangLi, rdpsin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit d1b3fdf into kubernetes-sigs:release-1.5 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants