-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure image OCI compliance #1205
Ensure image OCI compliance #1205
Conversation
Hi @torredil. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since this will be part of v1.5.3, we should probably submit a PR against the release-1.5 branch. |
5ef82a9
to
7580533
Compare
/ok-to-test |
7580533
to
9548cf8
Compare
Signed-off-by: Eddie Torres <torredil@amazon.com>
9548cf8
to
0045911
Compare
/test pull-aws-ebs-csi-driver-external-test-eks |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndyXiangLi, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
os.version
is being incorrectly set which makes the image not OCI compliant and thus incompatible with containerd. Theos.version
on Windows should be a 4-part string similar to 10.0.14393.1066. Reference: https://github.com/opencontainers/image-spec/blob/main/specs-go/v1/config.go#L100What testing is done?
docker manifest inspect
.