hash volume name to get client token #1041
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdhanan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| @@ -320,9 +322,12 @@ func (c *cloud) CreateDisk(ctx context.Context, volumeName string, diskOptions * | |||
| } | |||
| } | |||
|
|
|||
| // We hash the volume name to generate a unique token that is less than or equal to 64 characters | |||
| clientToken := sha256.Sum256([]byte(volumeName)) | |||
There was a problem hiding this comment.
I think encoding is enough here, why do we need extra hashing?
There was a problem hiding this comment.
in this step, we are hashing the volumeName, resulting in a byte slice of length 32 (256 bits). in the next step, we hex encode the slice and convert it to a string, ensuring it is always length 64. i think this is the safest way to guarantee we never exceed 64 characters in the token.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
…041-origin-release-1.2 [release-1.2] Automated cherry pick of #1041: hash volume name to get client token
Is this a bug fix or adding new feature?
fixes #1038
What is this PR about? / Why do we need it?
hash the volume name using sha-256 in case the name is longer than 64 characters.
What testing is done?
manually tested that a volume could be created with new token