fix: k8s client setup if agent service account auth is not used #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
ipochi
force-pushed
the
imran/fix-k8sclient-for-mtls
branch
2 times, most recently
from
c4a2ca5 to
0b9115e
Compare
|
/retest |
|
e2e test failure is related to actions/runner-images#11985 /cc @cheftako |
ipochi
changed the title
Currently the setting up of k8s client is broken if service account
authentication is not used between server and agent.
This condition `if o.AgentNamespace != "" {` acts as a gatekeeper for
setting the k8s client which worked fine previously as server never
needed to talk to apiserver apart from authenticating agents using
service account token.
However when lease controller logic was added, it meant that setting up
k8s client was required if lease controller was enabled but
authentication was done using mTLS instead of service account
authentication.
This fixes that.
Closing kubernetes-sigs#728 in favour of this.
Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
ipochi
force-pushed
the
imran/fix-k8sclient-for-mtls
branch
from
0b9115e to
3e4b939
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, ipochi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Change looks good. Lets see what we need to do to get the tests healthy. |
|
/retest |
|
ipv6 runners have a kernel bug actions/runner-images#11985 , this is the reason of CI failed. |
There is an error in github actions runner that runs on 22.04. This issue hasn't been rectified yet but the issue is not reported on 24.04 issue details: actions/runner-images#11985 So this bumps the action to run on ubuntu 24.04 Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
switching to 24.04 github action runner introduces this error chmod: cannot operate on dangling symlink '/usr/local/bin/now' hence instead of chmod all binaries present in /usr/local/bin, we only chmod the binaries that we copy. Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the setting up of k8s client is broken if service account
authentication is not used between server and agent.
This condition
if o.AgentNamespace != "" {acts as a gatekeeper forsetting the k8s client which worked fine previously as server never
needed to talk to apiserver apart from authenticating agents using
service account token.
However when lease controller logic was added, it meant that setting up
k8s client was required if lease controller was enabled but
authentication was done using mTLS instead of service account
authentication.
This fixes that.
Closing #728 in favour of this.