Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

configure machine deployment #30

Merged
merged 1 commit into from
Jun 27, 2019
Merged

configure machine deployment #30

merged 1 commit into from
Jun 27, 2019

Conversation

amy
Copy link
Contributor

@amy amy commented Jun 26, 2019

Configures machine deployment YAML.
Addresses: #29

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2019
chuckha
chuckha suggested changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! you will need to copy the other sections in the main() function and add the name of this command to the case statement, I'd suggest naming it machine-deployment

cmd/capdctl/main.go Outdated Show resolved Hide resolved
cmd/capdctl/main.go Outdated Show resolved Hide resolved
cmd/capdctl/main.go Outdated Show resolved Hide resolved
cmd/capdctl/main.go Outdated Show resolved Hide resolved
cmd/capdctl/main.go Outdated Show resolved Hide resolved
cmd/capdctl/main.go Show resolved Hide resolved
cmd/capdctl/main.go Show resolved Hide resolved
cmd/capdctl/main.go Show resolved Hide resolved
cmd/capdctl/main.go Outdated Show resolved Hide resolved
@neolit123
Copy link
Contributor

/test pull-cluster-api-provider-docker-verify
testing if the CI works.

@neolit123
Copy link
Contributor 

Found trailing whitespace in the follow files:
./README.md:9:- `go,  1.12+` 
./README.md:47:1. Install capdctl: 
Verifying new lines at end of files...
Found whitespace errors!

it works and it caught errors from previous PRs that already merged.

@amy amy force-pushed the machineDeployment branch 4 times, most recently from b8341c5 to 9d1e0ac Compare June 27, 2019 17:08
chuckha
chuckha reviewed Jun 27, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor comments.

lgtm overall

cmd/capdctl/main.go Outdated Show resolved Hide resolved
cmd/capdctl/main.go Outdated Show resolved Hide resolved
cmd/capdctl/main.go Outdated Show resolved Hide resolved
@amy amy force-pushed the machineDeployment branch 2 times, most recently from 1e6bf0b to 80a7a71 Compare June 27, 2019 17:22
@amy
Copy link
Contributor Author

amy commented Jun 27, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

@amy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chuckha
chuckha approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amy, chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@amy amy changed the title [WIP] configure machine deployment configure machine deployment Jun 27, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2019
@chuckha
Copy link
Contributor

chuckha commented Jun 27, 2019

/test pull-cluster-api-provider-docker-verify

@chuckha
Copy link
Contributor

chuckha commented Jun 27, 2019

I don't usually do this but the build is broken due to CI and this has the fixes. The other exception is that this is still a new project and we're looking for reviewers!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3ac0512 into kubernetes-retired:master Jun 27, 2019
This was referenced Jun 27, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chuckha chuckha chuckha approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@chuckha chuckha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amy @neolit123 @k8s-ci-robot @chuckha