Retain volumesnapshot-being-created annotation until readyToUse=true

[pwschuurman]

What type of PR is this?
/kind bug

What this PR does / why we need it:
In createSnapshotWrapper(), the snapshot.storage.kubernetes.io/volumesnapshot-being-created annotation is removed even if the snapshot is not marked as readyToUse true. This is inconsistent with the same logic in syncContent() where we only remove the annotation if the snapshot content is ready:

external-snapshotter/pkg/sidecar-controller/snapshot_controller.go

Line 102 in 59d7297

_, err = ctrl.removeAnnVolumeSnapshotBeingCreated(content)

Which issue(s) this PR fixes:

This change may reduce symptoms seen in #1282. However this does not fix the root cause of immedate vs. scheduled exponential backoff requeuing.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove VolumeSnapshotContent ``snapshot.storage.kubernetes.io/volumesnapshot-being-created annotation only when status.readyToUse is true

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pwschuurman
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pwschuurman]

/assign @sunnylovestiramisu

[nixpanic]

/lgtm

Thanks!

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[xing-yang]

As described in the comments, the annotation is only needed before the snapshot is cut on the storage system. After the snapshot is cut, a snapshot id will be returned and can be used to identify the snapshot on the storage system (if user chooses to delete the snapshot).
I don't see why we have to wait until the snapshot is post processed and ready to use set to true.