Closed as not planned
Closed as not planned
Description
external-snapshotter/pkg/sidecar-controller/groupsnapshot_helper.go
Lines 433 to 497 in fa9de9c
The above code seems to be buggy and i got around 200 volumesnapshots/volumesnapshotcontent created for a single volumegroupsnapshot with single PVC.
It works as below
- Create volumegroupsnapshot with csi driver
- Get the response and generate VS and VSC name based on the timestamp
- Create the volumesnapshotcontent
- Create the volumesnapshot
- Update volumesnapshotcontent
Repeat steps 3,4,5 for all the snapshots in the volumegroupsnapshot RPC response and at last update the volumegroupsnapshotcontent status with VSC names.
If there are any issues in 3,4,5 steps or if the csi-snapshotter is restarted we might end up having stale resources that need to be garbage collected.