Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove provisioner argument, update README #186

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

jarrpa
Copy link
Contributor

@jarrpa jarrpa commented Dec 9, 2018

Resolves #162

Signed-off-by: Jose A. Rivera jarrpa@redhat.com

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 9, 2018
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2018
@jarrpa jarrpa force-pushed the remove-provisioner-arg branch from 71f7680 to 91dfec3 Compare December 9, 2018 23:32
@jarrpa
Copy link
Contributor Author

jarrpa commented Dec 9, 2018

@msau42 PTAL

@msau42
Copy link
Collaborator

msau42 commented Dec 10, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2018
@msau42
Copy link
Collaborator

msau42 commented Dec 10, 2018

We need to remember to add this to the release notes

@jarrpa
Copy link
Contributor Author

jarrpa commented Dec 10, 2018

@msau42 Who would be good to approve this PR?

@msau42
Copy link
Collaborator

msau42 commented Dec 10, 2018

/assign @jsafrane

@msau42
Copy link
Collaborator

msau42 commented Dec 18, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit 81dd46e into kubernetes-csi:master Dec 18, 2018
@msau42 msau42 mentioned this pull request Jan 23, 2019
kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants