-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No credential in DeleteVolume RPC when defined StorageClass for PV is deleted already #222
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
I believe #274 does this now and passes no secret on delete if it can't find it. /close |
@msau42: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6613c3980 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae993d Update k8s image repo url 77e47cce8 Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b09 Fix dep version mismatch 8f839056a Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94dd5 Update go version to 1.20 to match k/k v1.27 e322ce5e5 Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a51209 test: fix golint error aa61bfd0c Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver 7563d1963 Update CSI_PROW_DRIVER_VERSION to v1.11.0 a2171bef0 Merge pull request kubernetes-csi#216 from msau42/process cb9878261 Merge pull request kubernetes-csi#217 from msau42/owners a11216e47 add new reviewers and remove inactive reviewers dd9867540 Add step for checking builds b66c08249 Merge pull request kubernetes-csi#214 from pohly/junit-fixes b9b6763bd filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit d4277839f filter-junit.go: preserve system error log 38e11468f prow.sh: publish individual JUnit files as separate artifacts git-subtree-dir: release-tools git-subtree-split: 6613c3980d1e418bebb7bc49d64c977cfff85671
6613c3980 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae993d Update k8s image repo url 77e47cce8 Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b09 Fix dep version mismatch 8f839056a Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94dd5 Update go version to 1.20 to match k/k v1.27 e322ce5e5 Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a51209 test: fix golint error aa61bfd0c Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver 7563d1963 Update CSI_PROW_DRIVER_VERSION to v1.11.0 a2171bef0 Merge pull request kubernetes-csi#216 from msau42/process cb9878261 Merge pull request kubernetes-csi#217 from msau42/owners a11216e47 add new reviewers and remove inactive reviewers dd9867540 Add step for checking builds b66c08249 Merge pull request kubernetes-csi#214 from pohly/junit-fixes b9b6763bd filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit d4277839f filter-junit.go: preserve system error log 38e11468f prow.sh: publish individual JUnit files as separate artifacts git-subtree-dir: release-tools git-subtree-split: 6613c3980d1e418bebb7bc49d64c977cfff85671
6613c3980 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae993d Update k8s image repo url 77e47cce8 Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b09 Fix dep version mismatch 8f839056a Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94dd5 Update go version to 1.20 to match k/k v1.27 e322ce5e5 Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a51209 test: fix golint error aa61bfd0c Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver 7563d1963 Update CSI_PROW_DRIVER_VERSION to v1.11.0 a2171bef0 Merge pull request kubernetes-csi#216 from msau42/process cb9878261 Merge pull request kubernetes-csi#217 from msau42/owners a11216e47 add new reviewers and remove inactive reviewers dd9867540 Add step for checking builds b66c08249 Merge pull request kubernetes-csi#214 from pohly/junit-fixes b9b6763bd filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit d4277839f filter-junit.go: preserve system error log 38e11468f prow.sh: publish individual JUnit files as separate artifacts git-subtree-dir: release-tools git-subtree-split: 6613c3980d1e418bebb7bc49d64c977cfff85671
…ded-version Decrease recommended version
6613c398 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae993 Update k8s image repo url 77e47cce Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b0 Fix dep version mismatch 8f839056 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94dd Update go version to 1.20 to match k/k v1.27 e322ce5e Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a5120 test: fix golint error aa61bfd0 Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver 7563d196 Update CSI_PROW_DRIVER_VERSION to v1.11.0 a2171bef Merge pull request kubernetes-csi#216 from msau42/process cb987826 Merge pull request kubernetes-csi#217 from msau42/owners a11216e4 add new reviewers and remove inactive reviewers dd986754 Add step for checking builds b66c0824 Merge pull request kubernetes-csi#214 from pohly/junit-fixes b9b6763b filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit d4277839 filter-junit.go: preserve system error log 38e11468 prow.sh: publish individual JUnit files as separate artifacts git-subtree-dir: release-tools git-subtree-split: 6613c3980d1e418bebb7bc49d64c977cfff85671
Observed the behavior when receiving RPC call for DeleteVolume and doesn't contain the credentials passed in the Storage Class.
The issue seems to be not handling it for case where StorageClass is deleted before the RPC request for DeleteVolume is in progress:
https://github.com/kubernetes-csi/external-provisioner/blob/master/pkg/controller/controller.go#L761
pkg/controller/controller.go:761
if storageClass, err := p.client.StorageV1().StorageClasses().Get(storageClassName, metav1.GetOptions{}); err == nil {
From above The error condition is not implemented when there is a storageclass defined but the storageClass is deleted before the PVC deletion in progress
In that case, the DeleteVolume request only send
VolumeId
without secretsThe text was updated successfully, but these errors were encountered: