Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver registrar can sometimes take 1 minute to start #76

Closed
saad-ali opened this issue Nov 26, 2018 · 6 comments
Closed

Driver registrar can sometimes take 1 minute to start #76

saad-ali opened this issue Nov 26, 2018 · 6 comments

Comments

@saad-ali
Copy link
Member

Driver registrar can sometimes take 1 minute to start. See kubernetes/kubernetes#71433 (comment)

Let's understand why, and see if we can reduce this.

@saad-ali
Copy link
Member Author

Relevant code:

for {
if !conn.WaitForStateChange(ctx, conn.GetState()) {
glog.V(4).Infof("Connection timed out")
return conn, nil // return nil, subsequent GetPluginInfo will show the real connection error
}
if conn.GetState() == connectivity.Ready {
glog.V(3).Infof("Connected")
return conn, nil
}
glog.V(4).Infof("Still trying, connection is %s", conn.GetState())
}

In this case it received TRANSIENT_FAILURE. Apparently doing nothing in that case doesn't fix anything.

@pohly
Copy link
Contributor

pohly commented Nov 27, 2018

Something that mitigates the issue is to put the CSI driver container first in the list of containers for the pod. I have seen timing related delays on a slow cluster because Kubernetes pulled images one-by-one, then started registrar first before it started pulling the CSI driver image.

But the real fix will be to make that connect loop iterate faster. This is code that should go into the new kubernetes-csi/csi-utils repo that we started to discuss for gRPC logging.

@msau42
Copy link
Collaborator

msau42 commented Nov 27, 2018

Another suggestion is to try different rpc options: kubernetes/kubernetes#71433 (comment)

@vladimirvivien
Copy link
Member

Investigating a fix/workaround based on suggestions here.

@vladimirvivien
Copy link
Member

Created PR - #78

@saad-ali saad-ali reopened this Dec 19, 2018
@lpabon
Copy link
Member

lpabon commented Jan 9, 2019

🛂 ⛔️
Hi, this repo has been split up into two repos:

This repo has been closed, and no new changes will be accepted. Please move your content to one of these repos.

Thank you,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants