single pod deployments #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
pohly
added a commit
to pohly/test-infra
that referenced
this pull request
May 3, 2021
kubernetes-csi/csi-driver-host-path#282 introduces two kinds of deployments, with one pod for sidecar and driver (now the default) individual pods for sidecars and drivers (what used to be the default, now in a "-prow" flavor for testing with Prow). We want to test both flavors before merging and periodically.
|
/test pull-kubernetes-csi-csi-driver-host-path-1-21-on-kubernetes-1-21 |
pohly
force-pushed
the
single-pod-deployments
branch
from
12d9b6e
to
b813602
Compare
pohly
added a commit
to pohly/test-infra
that referenced
this pull request
May 4, 2021
kubernetes-csi/csi-driver-host-path#282 introduces two kinds of deployments, with one pod for sidecar and driver (now the default) and individual pods for sidecars and drivers (what used to be the default, now in a "-prow" flavor for testing with Prow). We want to test both flavors before merging and periodically.
pohly
added a commit
to pohly/test-infra
that referenced
this pull request
May 4, 2021
kubernetes-csi/csi-driver-host-path#282 introduces two kinds of deployments, with one pod for sidecar and driver (now the default) and individual pods for sidecars and drivers (what used to be the default, now in a "-prow" flavor for testing with Prow). We want to test both flavors before merging and periodically.
pohly
added a commit
to pohly/test-infra
that referenced
this pull request
May 4, 2021
kubernetes-csi/csi-driver-host-path#282 introduces two kinds of deployments, with one pod for sidecar and driver (now the default) and individual pods for sidecars and drivers (what used to be the default, now in a "-prow" flavor for testing with Prow). We want to test both flavors before merging and periodically.
pohly
added a commit
to pohly/test-infra
that referenced
this pull request
May 4, 2021
kubernetes-csi/csi-driver-host-path#282 introduces two kinds of deployments, with one pod for sidecar and driver (now the default) and individual pods for sidecars and drivers (what used to be the default, now in a "-test" flavor for testing with Prow). We want to test both flavors before merging and periodically.
|
/retest |
pohly
force-pushed
the
single-pod-deployments
branch
2 times, most recently
from
b2bdc34
to
43c5d7e
Compare
All deployments are greater than 1.16, therefore we can deploy csi-hostpath-snapshotclass.yaml unconditionally.
The kubernetes-x.yy deployments now use the same pod for driver and sidecars, which is the usual way of deploying them. The alternative "-prow" deployments use separate pods for them to test that the individual RBAC rules are correct.
pohly
force-pushed
the
single-pod-deployments
branch
from
43c5d7e
to
194132f
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest Test flake (?) in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_csi-driver-host-path/282/pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-1-21/1389899497311571968: "External Storage [Driver: hostpath.csi.k8s.io] [Testpattern: Dynamic PV (default fs)] subPath should support existing directories when readOnly specified in the volumeSource" |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We want to show (and, in Kubernetes, test) deployments with all sidecars and driver in the same pod. We still want to test with individual pods to ensure that RBAC rules work, therefore we need both flavors.
Which issue(s) this PR fixes:
Fixes #192
Special notes for your reviewer:
Based on PR #281
Depends on an updated prow.sh and new Prow jobs for the non-default deployments.
Does this PR introduce a user-facing change?: