update images, add Kubernetes 1.20, prepare for v1.5.0 release #238

pohly · 2021-01-27T10:50:41Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Kubernetes 1.17 is no longer supported, but because all sidecars still
work on it there is no need to remove the "deploy/kubernetes-1.17"
folder either. Instead, all sidecar and driver images merely get
updated.

The CSI hostpath image update is important because the recently added
health check sidecar depends on the new version.

Kubernetes 1.20 is where officially the v1 snapshotter API is
introduced. Therefore the new deployment for it also uses the
external-snapshotter 4.x and the v1 APIs.

** Note for reviewers ***

I am including a CHANGELOG/CHANGELOG-1.5.md in this PR for the sake of expedience. It already includes this PR, so once it is merged, we can tag v1.5.0.

Does this PR introduce a user-facing change?:

image updates and deployment for Kubernetes 1.20 with external-snapshotter v4.0.0.

pohly · 2021-01-27T11:50:56Z

/retest

Test flake (?) on 1.20: "External Storage [Driver: hostpath.csi.k8s.io] [Testpattern: Dynamic PV (default fs)] subPath should support restarting containers using directory as subpath [Slow]"

xing-yang · 2021-01-27T14:13:44Z

deploy/kubernetes-1.17/hostpath/csi-hostpath-plugin.yaml

@@ -91,7 +91,7 @@ spec:
            name: csi-data-dir

        - name: hostpath
-          image: k8s.gcr.io/sig-storage/hostpathplugin:v1.4.0
+          image: k8s.gcr.io/sig-storage/hostpathplugin:v1.5.0


Will CI start to fail for other repos if we merge this before releasing hostpathplugin v1.5.0?

No. Those other pre-merge jobs intentionally use a fixed version of the hostpath repo to prevent such breakage.

What normally would have happened is that the periodic jobs (briefly) fail until the new image is available. But those jobs were already broken when adding the health check sidecar, so this is not going to make them worse 😅

msau42 · 2021-01-27T18:19:50Z

CHANGELOG/CHANGELOG-1.5.md

+## Changes by Kind
+
+### Feature
+ - Adds snapshot beta CRD deployment for 1.17 ([#98](https://github.com/kubernetes-csi/csi-driver-host-path/pull/98), [@xing-yang](https://github.com/xing-yang))


We deploy snapshot CRDs in prow, not the hostpath driver right?

It was another PR that doesn't belong here.

msau42 · 2021-01-27T18:21:19Z

CHANGELOG/CHANGELOG-1.5.md

+
+### Feature
+ - Adds snapshot beta CRD deployment for 1.17 ([#98](https://github.com/kubernetes-csi/csi-driver-host-path/pull/98), [@xing-yang](https://github.com/xing-yang))
+ - Ephemeral inline volumes in addition to normal volumes on Kubernetes 1.16 ([#97](https://github.com/kubernetes-csi/csi-driver-host-path/pull/97), [@pohly](https://github.com/pohly))


This has been available since 1.2.

I think the release-notes tool is confused by the release-tools subtree commit messages and picking up csi-release-tools PR numbers. Does the new method of squashing fix this?

Darn. I did check one PR which looked odd and that turned out to be correct, so I trusted the tool for the rest 😢

I suppose squashing helps, but I haven't tried that myself - I don't do releases that often.

msau42 · 2021-01-27T18:22:28Z

CHANGELOG/CHANGELOG-1.5.md

+
+### Bug or Regression
+ - Add topology to the CreateVolumeResponse for existing volumes ([#231](https://github.com/kubernetes-csi/csi-driver-host-path/pull/231), [@Jiawei0227](https://github.com/Jiawei0227))
+ - Fixed raw block volumes on hosts that don't have /dev/loop- devices pre-defined ([#109](https://github.com/kubernetes-csi/csi-driver-host-path/pull/109), [@pohly](https://github.com/pohly))


this is old?

msau42 · 2021-01-27T18:23:22Z

CHANGELOG/CHANGELOG-1.5.md

+
+### Uncategorized
+ - Build with Go 1.15 ([#198](https://github.com/kubernetes-csi/csi-driver-host-path/pull/198), [@pohly](https://github.com/pohly))
+ - Migrated to Go modules, so the source builds also outside of GOPATH. ([#103](https://github.com/kubernetes-csi/csi-driver-host-path/pull/103), [@pohly](https://github.com/pohly))


msau42 · 2021-01-27T18:27:31Z

deploy/kubernetes-1.17/hostpath/csi-hostpath-driverinfo.yaml

@@ -1,4 +1,4 @@
-apiVersion: storage.k8s.io/v1beta1
+apiVersion: storage.k8s.io/v1


v1 is only available in 1.18

So shall we rename kubernetes-1.17 to kubernetes-1.18 after all?

Sounds good

Done and force pushed (because it is a fix for the incorrect use of v1 in kubernetes-1.17).

pohly · 2021-01-27T19:23:14Z

I've pushed a version where I manually verified each PR that gets listed in the changelog.

Kubernetes 1.17 is no longer supported and by updating to 1.18 as minimal version we can use the GA CSIDriver v1 API. Also, all sidecar and driver images get updated. The CSI hostpath image update is important because the recently added health check sidecar depends on the new version. Kubernetes 1.20 is where officially the v1 snapshotter API is introduced. Therefore the new deployment for it also uses the external-snapshotter 4.x and the v1 APIs.

msau42 · 2021-01-27T20:29:12Z

deploy/kubernetes-1.20/hostpath/csi-hostpath-plugin.yaml

+# are needed only because of condition explained in
+# https://github.com/kubernetes/kubernetes/issues/69608
+
+kind: Service


did we miss removing these as part of #196?

msau42 · 2021-01-27T20:32:24Z

deploy/kubernetes-1.20/hostpath/csi-hostpath-plugin.yaml

+          volumeMounts:
+            - name: socket-dir
+              mountPath: /csi
+        - name: csi-external-health-monitor-controller


Putting the controller here seems inconsistent with how we currently have other controller sidecars in separate manifests. I guess we didn't really conclude how we want to go in #192

That came from #210. I just copied it.

FWIW, I agree that it seems inconsistent. I don't know whether it had to be done this way.

msau42 · 2021-01-27T21:50:54Z

/lgtm
/approve

Let's followup on these cleanup items separately.

k8s-ci-robot · 2021-01-27T21:51:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 27, 2021

k8s-ci-robot requested review from jsafrane and xing-yang January 27, 2021 10:50

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 27, 2021

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2021

pohly changed the title ~~deploy: update images, add Kubernetes 1.20~~ update images, add Kubernetes 1.20, prepare for v1.5.0 release Jan 27, 2021

xing-yang reviewed Jan 27, 2021

View reviewed changes

msau42 reviewed Jan 27, 2021

View reviewed changes

pohly force-pushed the release-1.5 branch from 9e1bf37 to 2473c53 Compare January 27, 2021 19:19

pohly force-pushed the release-1.5 branch from 2473c53 to a953d2c Compare January 27, 2021 20:09

pohly added 2 commits January 27, 2021 21:10

release: v1.5.0

2100403

pohly force-pushed the release-1.5 branch from a953d2c to 2100403 Compare January 27, 2021 20:11

msau42 reviewed Jan 27, 2021

View reviewed changes

k8s-ci-robot assigned msau42 Jan 27, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2021

k8s-ci-robot merged commit 78a7533 into kubernetes-csi:master Jan 27, 2021

msau42 mentioned this pull request Feb 3, 2021

README.md: document usage of --squash kubernetes-csi/csi-release-tools#129

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update images, add Kubernetes 1.20, prepare for v1.5.0 release #238

update images, add Kubernetes 1.20, prepare for v1.5.0 release #238

pohly commented Jan 27, 2021 •

edited

Loading

pohly commented Jan 27, 2021

xing-yang Jan 27, 2021

pohly Jan 27, 2021

msau42 Jan 27, 2021

pohly Jan 27, 2021

msau42 Jan 27, 2021

msau42 Jan 27, 2021

pohly Jan 27, 2021

msau42 Jan 27, 2021

msau42 Jan 27, 2021

msau42 Jan 27, 2021

pohly Jan 27, 2021

msau42 Jan 27, 2021

pohly Jan 27, 2021

pohly commented Jan 27, 2021

msau42 Jan 27, 2021

pohly Jan 27, 2021

msau42 Jan 27, 2021

pohly Jan 27, 2021

pohly Jan 27, 2021

msau42 commented Jan 27, 2021

k8s-ci-robot commented Jan 27, 2021

		@@ -1,4 +1,4 @@
		apiVersion: storage.k8s.io/v1beta1
		apiVersion: storage.k8s.io/v1

update images, add Kubernetes 1.20, prepare for v1.5.0 release #238

update images, add Kubernetes 1.20, prepare for v1.5.0 release #238

Conversation

pohly commented Jan 27, 2021 • edited Loading

pohly commented Jan 27, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pohly commented Jan 27, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msau42 commented Jan 27, 2021

k8s-ci-robot commented Jan 27, 2021

pohly commented Jan 27, 2021 •

edited

Loading