Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment: blacklist updating attacher in 1.14 to canary #116

Merged
merged 1 commit into from
Nov 4, 2019
Merged

deployment: blacklist updating attacher in 1.14 to canary #116

merged 1 commit into from
Nov 4, 2019

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Nov 4, 2019

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

The new v2.0.0 of the external-attacher that is used with 1.15 and
1.16 is not compatible with the 1.14 deployment (RBAC change) and thus
the canary test job for 1.14 must not use the canary version of the
external-attacher.

Does this PR introduce a user-facing change?:

NONE

@pohly
deployment: blacklist updating attacher in 1.14 to canary
4eada02 
The new v2.0.0 of the external-attacher that is used with 1.15 and
1.16 is not compatible with the 1.14 deployment (RBAC change) and thus
the canary test job for 1.14 must not use the canary version of the
external-attacher.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2019
@pohly pohly mentioned this pull request Nov 4, 2019
Merged
@msau42
Copy link
Collaborator

msau42 commented Nov 4, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit b5e3673 into kubernetes-csi:master Nov 4, 2019
fengzixu pushed a commit to fengzixu/csi-driver-host-path that referenced this pull request Dec 31, 2020
@k8s-ci-robot
Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
86ff580 
allow export registry name
fengzixu added a commit to fengzixu/csi-driver-host-path that referenced this pull request Jan 4, 2021
@fengzixu
Squashed 'release-tools/' changes from c6a88c6..2bb7525
b80bed3 
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: 2bb7525
fengzixu added a commit to fengzixu/csi-driver-host-path that referenced this pull request Jan 4, 2021
@fengzixu
Squashed 'release-tools/' changes from c6a88c6..2bb7525
7e752df 
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: 2bb7525
kvaps added a commit to kvaps/csi-driver-host-path that referenced this pull request Jan 19, 2021
@kvaps
Squashed 'release-tools/' changes from c6a88c6..ece0f50
5961195 
ece0f50 check namespace for snapshot-controller
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: ece0f50
kvaps added a commit to kvaps/csi-driver-host-path that referenced this pull request Jan 25, 2021
@kvaps
Squashed 'release-tools/' changes from c6a88c6..fe1f284
dddc2c4 
fe1f284 Merge pull request kubernetes-csi#121 from kvaps/namespace-check
8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master
1c94220 fix: fix a bug of csi-sanity
a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate
ece0f50 check namespace for snapshot-controller
dbd8967 verify-boilerplate.sh: fix path to script
9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks
ad29307 Make the spelling and boilerplate checks optional
5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
48186eb Fix spelling and boilerplate errors
71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
981be3f Adding spelling and boilerplate checks.
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: fe1f284
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Mar 15, 2021
@pohly
Squashed 'release-tools/' changes from 7bc70e5..00bc64a9
3c0f612 
00bc64a9 remove travis.yml, Go 1.16
REVERT: 7bc70e5 Merge pull request kubernetes-csi#129 from pohly/squash-documentation
REVERT: e0b02e7 README.md: document usage of --squash
REVERT: 316cb95 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate
REVERT: 26e2ab1 fix: default boilerplate path
REVERT: 1add8c1 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag
REVERT: 3e811d6 prow.sh: fix "on-master" prow jobs
REVERT: 1d60e77 Merge pull request kubernetes-csi#131 from pohly/kubernetes-1.20-tag
REVERT: 9f10459 prow.sh: support building Kubernetes for a specific version
REVERT: fe1f284 Merge pull request kubernetes-csi#121 from kvaps/namespace-check
REVERT: 8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master
REVERT: 1c94220 fix: fix a bug of csi-sanity
REVERT: a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate
REVERT: ece0f50 check namespace for snapshot-controller
REVERT: dbd8967 verify-boilerplate.sh: fix path to script
REVERT: 9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks
REVERT: ad29307 Make the spelling and boilerplate checks optional
REVERT: 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
REVERT: 48186eb Fix spelling and boilerplate errors
REVERT: 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
REVERT: 981be3f Adding spelling and boilerplate checks.
REVERT: 2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
REVERT: 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
REVERT: 9318c6c cloud build: double the timeout, now 1 hour
REVERT: 4ab8b15 use the tag to replace commit of csi-test
REVERT: 5d74e45 change the csi-test import path to v4
REVERT: 7dcd0a9 upgrade csi-test to v4.0.2
REVERT: 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
REVERT: c3a9662 allow export image name and registry name
REVERT: c6a88c6 Merge pull request kubernetes-csi#113 from xing-yang/install_snapshot_controller
REVERT: 45ec4c6 Fix the install of snapshot CRDs and controller
REVERT: 5d874cc Merge pull request kubernetes-csi#112 from xing-yang/cleanup
REVERT: 79bbca7 Cleanup
REVERT: d437673 Merge pull request kubernetes-csi#111 from xing-yang/update_snapshot_v1_rc
REVERT: 57718f8 Update snapshot CRD version
REVERT: 4aff857 Merge pull request kubernetes-csi#109 from pohly/alpha-test-defaults
REVERT: 0427289 Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build-workaround
REVERT: 9a370ab prow.sh: work around "kind build node-image" failure
REVERT: 522361e prow.sh: only run alpha tests for latest Kubernetes release
REVERT: 22c0395 Merge pull request kubernetes-csi#108 from bnrjee/master
REVERT: b5b447b Add go ldflags using LDFLAGS at the time of compilation
REVERT: 16f4afb Merge pull request kubernetes-csi#107 from pohly/kind-update

git-subtree-dir: release-tools
git-subtree-split: 00bc64a9b7c2585676b1da301a7acae8797229a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@vladimirvivien vladimirvivien Awaiting requested review from vladimirvivien

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pohly @msau42 @k8s-ci-robot