-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system:serviceaccount:cert-manager:csi-snapshotter cannot create resource ... #127
Comments
https://github.com/kubernetes-csi/csi-driver-host-path/blob/master/deploy/kubernetes-1.16/hostpath/csi-hostpath-snapshotter.yaml#L43 install v1.2.0 of the external-snapshotter, which means that the deploy script should download the corresponding RBAC rules, which have: https://github.com/kubernetes-csi/external-snapshotter/blob/b3f591d85cce516e431c70e5337d5c67611ae2fe/deploy/kubernetes/rbac.yaml#L50-L52 "Should" - some of the recent changes to the script broke the content of
Everything between The reason is a missing closing bracket, this fixes it:
The more interesting question is: why was this not caught by the CI when merging #98? The test job shows the same broken output (https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_csi-driver-host-path/98/pull-kubernetes-csi-csi-driver-host-path-1-16-on-kubernetes-1-16/1202409554004938755/build-log.txt). Does the KinD cluster perhaps not have RBAC enforcement turned on? |
/cc @msau42 |
The other problem is that the wrong URL didn't lead to some obvious error and early aborting of the script. For wget, it is the The actual download happens with
@tpoxa: does your version perhaps handle this differently? Which version is that? I bet there is a difference in
|
This branch did not make big difference for me.
|
@tpoxa which version of kubectl are you using? Can you check that you now get the expected RBAC rules? I have:
|
|
That looks sane to me. Sorry, I'm out of ideas. |
@ggriffiths can you please take a look? thanks. |
Hold on. Running the 1.16 versions of the hostpath deployment against a 1.12 cluster probably is going to have a lot of problems |
Sorry ignore my last comment. I misread the kubectl output. What is the cluster version? |
I'm not sure why #98 didn't catch this. I think we tested as far back as We create the CRDs in prow.sh before the snapshotter is deployed. Seems like the error is coming from here in the old snapshotter: |
Grant Griffiths <notifications@github.com> writes:
I'm not sure why #98 didn't catch this. I think we tested as far back as
`pull-kubernetes-csi-csi-driver-host-path-1-14-on-kubernetes-1-14`, so
if it's 1.16 hostpath on an older version, that might have issues.
It seems to depend on the kubectl version. A recent kubectl silently
ignored the garbage after the URL.
|
|
Its clean kubernetes installation. I only have cert-manager installed with Helm.
Maybe its somehow related with Cert-manager finalizers or so... Sorry I am still quite new to k8s. |
I think the issue is the namespaces. The cluster rolebinding shows csi-snapshotter service account in default namespace:
But your error message is csi-snapshotter in cert-manager namespace.
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master 1c94220 fix: fix a bug of csi-sanity a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate dbd8967 verify-boilerplate.sh: fix path to script 9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks ad29307 Make the spelling and boilerplate checks optional 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests 48186eb Fix spelling and boilerplate errors 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests 981be3f Adding spelling and boilerplate checks. git-subtree-dir: release-tools git-subtree-split: 8fdf0f7
fe1f284 Merge pull request kubernetes-csi#121 from kvaps/namespace-check 8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master 1c94220 fix: fix a bug of csi-sanity a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate ece0f50 check namespace for snapshot-controller dbd8967 verify-boilerplate.sh: fix path to script 9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks ad29307 Make the spelling and boilerplate checks optional 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests 48186eb Fix spelling and boilerplate errors 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests 981be3f Adding spelling and boilerplate checks. 2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout 9318c6c cloud build: double the timeout, now 1 hour 4ab8b15 use the tag to replace commit of csi-test 5d74e45 change the csi-test import path to v4 7dcd0a9 upgrade csi-test to v4.0.2 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name c3a9662 allow export image name and registry name git-subtree-dir: release-tools git-subtree-split: fe1f284
00bc64a9 remove travis.yml, Go 1.16 REVERT: 7bc70e5 Merge pull request kubernetes-csi#129 from pohly/squash-documentation REVERT: e0b02e7 README.md: document usage of --squash REVERT: 316cb95 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate REVERT: 26e2ab1 fix: default boilerplate path REVERT: 1add8c1 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag REVERT: 3e811d6 prow.sh: fix "on-master" prow jobs REVERT: 1d60e77 Merge pull request kubernetes-csi#131 from pohly/kubernetes-1.20-tag REVERT: 9f10459 prow.sh: support building Kubernetes for a specific version REVERT: fe1f284 Merge pull request kubernetes-csi#121 from kvaps/namespace-check REVERT: 8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master REVERT: 1c94220 fix: fix a bug of csi-sanity REVERT: a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate REVERT: ece0f50 check namespace for snapshot-controller REVERT: dbd8967 verify-boilerplate.sh: fix path to script REVERT: 9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks REVERT: ad29307 Make the spelling and boilerplate checks optional REVERT: 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests REVERT: 48186eb Fix spelling and boilerplate errors REVERT: 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests REVERT: 981be3f Adding spelling and boilerplate checks. REVERT: 2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master REVERT: 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout REVERT: 9318c6c cloud build: double the timeout, now 1 hour REVERT: 4ab8b15 use the tag to replace commit of csi-test REVERT: 5d74e45 change the csi-test import path to v4 REVERT: 7dcd0a9 upgrade csi-test to v4.0.2 REVERT: 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name REVERT: c3a9662 allow export image name and registry name REVERT: c6a88c6 Merge pull request kubernetes-csi#113 from xing-yang/install_snapshot_controller REVERT: 45ec4c6 Fix the install of snapshot CRDs and controller REVERT: 5d874cc Merge pull request kubernetes-csi#112 from xing-yang/cleanup REVERT: 79bbca7 Cleanup REVERT: d437673 Merge pull request kubernetes-csi#111 from xing-yang/update_snapshot_v1_rc REVERT: 57718f8 Update snapshot CRD version REVERT: 4aff857 Merge pull request kubernetes-csi#109 from pohly/alpha-test-defaults REVERT: 0427289 Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build-workaround REVERT: 9a370ab prow.sh: work around "kind build node-image" failure REVERT: 522361e prow.sh: only run alpha tests for latest Kubernetes release REVERT: 22c0395 Merge pull request kubernetes-csi#108 from bnrjee/master REVERT: b5b447b Add go ldflags using LDFLAGS at the time of compilation REVERT: 16f4afb Merge pull request kubernetes-csi#107 from pohly/kind-update git-subtree-dir: release-tools git-subtree-split: 00bc64a9b7c2585676b1da301a7acae8797229a9
verify-boilerplate.sh: fix path to script
Installation failed after 5m tmeout
The text was updated successfully, but these errors were encountered: