Unittests for portforwarding ability added in python-base. by iciclespider · Pull Request #1237 · kubernetes-client/python

iciclespider · 2020-08-24T03:42:12Z

Looking for feed back if this looks on track as a way of implementing port forwarding.

These unittest additions provide usage examples for the port forwarding proposal here: kubernetes-client/python-base#210

Also added a port forwarding example in the examples directory.

#166

k8s-ci-robot · 2020-08-24T03:42:15Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-08-24T03:42:19Z

Welcome @iciclespider!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

iciclespider · 2020-08-24T04:50:30Z

/check-cla

iciclespider · 2020-08-24T04:51:00Z

/assign @yliaog

yliaog · 2020-09-02T21:29:47Z

examples/pod_portforward.py

+        if isinstance(dns_name, bytes):
+            dns_name = dns_name.decode()
+        # Look for "<pod-name>.<namspace>.kubernetes" dns names and if found
+        # provide a socket that is port forwarded to the kuberntest pod.


s/kuberntest/kubernetes/

yliaog · 2020-09-02T21:45:05Z

examples/pod_portforward.py

+                }]
+            }
+        }
+        resp = api_instance.create_namespaced_pod(body=pod_manifest,


resp is not checked

This was copied and pasted from the pod_exec.py example, where it also does not check it. If there is an error, an exception would be thrown. I removed the assignment in this example.

yliaog · 2020-09-03T00:11:23Z

examples/pod_portforward.py

+    config.load_kube_config()
+    c = Configuration()
+    c.assert_hostname = False
+    #Configuration.set_default(c)


instead of commenting it out, the following should work:

c = Configuration.get_default_copy()
c.assert_hostname = False
Configuration.set_default(c)

iciclespider · 2020-09-06T19:30:07Z

@yliaog I submitted another commit for review.

iciclespider · 2020-09-08T05:56:34Z

https://travis-ci.org/github/kubernetes-client/python/jobs/725011007 failure, please fix.

I got everything to pass, except for the unittest module that is attempting to import portforward, which does not yet exist in the kubernetes/base git submodule.

yliaog · 2020-09-08T17:11:07Z

/retest

yliaog · 2020-09-08T17:11:25Z

/approve

yliaog · 2020-09-08T17:11:39Z

/lgtm

iciclespider · 2020-09-08T22:31:02Z

/test all

k8s-ci-robot · 2020-09-08T22:31:15Z

@iciclespider: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2020-09-09T01:09:35Z

/ok-to-test

roycaihw · 2020-09-09T01:11:01Z

/test all

k8s-ci-robot · 2020-09-09T01:11:03Z

@roycaihw: No presubmit jobs available for kubernetes-client/python@master

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2020-09-09T01:20:08Z

@iciclespider Could you update the submodule to fix the import failure? https://github.com/kubernetes-client/python/blob/master/devel/submodules.md#update-submodule

k8s-ci-robot · 2020-09-09T02:07:05Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

…ation.

yliaog · 2020-09-09T03:29:02Z

/lgtm
/approve

k8s-ci-robot · 2020-09-09T03:29:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iciclespider, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 24, 2020

k8s-ci-robot requested review from roycaihw and yliaog August 24, 2020 03:42

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 24, 2020

iciclespider mentioned this pull request Aug 24, 2020

Implement port forwarding. kubernetes-client/python-base#210

Merged

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 24, 2020

k8s-ci-robot assigned yliaog Aug 24, 2020

iciclespider force-pushed the port-forwarding branch from c57ddfc to 575b610 Compare August 27, 2020 07:53

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 27, 2020

iciclespider force-pushed the port-forwarding branch 10 times, most recently from c373b9d to bba78a6 Compare September 2, 2020 04:32

Unittests and example for portforwarding ability added in python-base.

fada718

iciclespider force-pushed the port-forwarding branch from bba78a6 to fada718 Compare September 2, 2020 04:32

yliaog reviewed Sep 3, 2020

View reviewed changes

iciclespider force-pushed the port-forwarding branch from 57381a2 to b122905 Compare September 6, 2020 21:14

iciclespider force-pushed the port-forwarding branch from 35036f9 to c1249c9 Compare September 8, 2020 05:47

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 9, 2020

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 9, 2020

iciclespider force-pushed the port-forwarding branch from bc10d93 to c78e84d Compare September 9, 2020 02:10

Update kubernetes/base to latest master with portforwarding implement…

3da49a2

…ation.

iciclespider force-pushed the port-forwarding branch from c78e84d to 3da49a2 Compare September 9, 2020 02:11

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 9, 2020

Install socat on Kubernetes node for use by port forwarding.

b1dd9c4

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020

k8s-ci-robot merged commit 4079c67 into kubernetes-client:master Sep 9, 2020

This was referenced Mar 15, 2021

Bump kubernetes from 8.0.1 to 12.0.1 in /tests sethbergman/kubernetes-ingress#23

Closed

Bump kubernetes from 8.0.1 to 12.0.1 in /perf-tests sethbergman/kubernetes-ingress#24

Closed

Conversation

iciclespider commented Aug 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 24, 2020

Uh oh!

k8s-ci-robot commented Aug 24, 2020

Uh oh!

iciclespider commented Aug 24, 2020

Uh oh!

iciclespider commented Aug 24, 2020

Uh oh!

yliaog Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

yliaog Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

iciclespider Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

yliaog Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

iciclespider commented Sep 6, 2020

Uh oh!

iciclespider commented Sep 8, 2020

Uh oh!

yliaog commented Sep 8, 2020

Uh oh!

yliaog commented Sep 8, 2020

Uh oh!

yliaog commented Sep 8, 2020

Uh oh!

iciclespider commented Sep 8, 2020

Uh oh!

k8s-ci-robot commented Sep 8, 2020

Uh oh!

roycaihw commented Sep 9, 2020

Uh oh!

roycaihw commented Sep 9, 2020

Uh oh!

k8s-ci-robot commented Sep 9, 2020

Uh oh!

roycaihw commented Sep 9, 2020

Uh oh!

k8s-ci-robot commented Sep 9, 2020

Uh oh!

yliaog commented Sep 9, 2020

Uh oh!

k8s-ci-robot commented Sep 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iciclespider commented Aug 24, 2020 •

edited

Loading