Make use of types for websocket library #26
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a compilation error I was getting when trying to import this library. The generated
exec.d.ts
file looked like this:which produced this error
I suspect that these changes also fix an error related to HTTP Basic Auth when using websockets connections because the
auth
property on the WebSocket connection was being set to an object instead of a${username}:${password}
string as NodeJS's HTTPS client expects.