Skip to content

Commit 78e948e

Browse files
committed
De-flake a test.
1 parent 73ae39a commit 78e948e

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

extended/src/test/java/io/kubernetes/client/extended/controller/builder/DefaultControllerBuilderTest.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,13 +183,17 @@ public void testBuildWatchEventNotificationShouldWork() {
183183
};
184184

185185
List<Request> controllerReceivingRequests = new ArrayList<>();
186-
Controller testController =
186+
final Semaphore latch = new Semaphore(1);
187+
latch.acquire();
188+
189+
final Controller testController =
187190
ControllerBuilder.defaultBuilder(informerFactory)
188191
.withReconciler(
189192
new Reconciler() {
190193
@Override
191194
public Result reconcile(Request request) {
192195
controllerReceivingRequests.add(request);
196+
latch.release();
193197
return new Result(false);
194198
}
195199
})
@@ -203,10 +207,10 @@ public Result reconcile(Request request) {
203207
controllerThead.submit(testController::run);
204208
informerFactory.startAllRegisteredInformers();
205209

206-
Request expectedRequest = new Request("hostname1/test-pod1");
207-
208-
cooldown();
210+
// Wait for the request to be processed.
211+
latch.acquire(1);
209212

213+
Request expectedRequest = new Request("hostname1/test-pod1");
210214
assertEquals(1, keyFuncReceivingRequests.size());
211215
assertEquals(expectedRequest, keyFuncReceivingRequests.get(0));
212216

0 commit comments

Comments
 (0)