Skip to content

Update exception message in KubernetesClientConfiguration.InCluster.cs #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2022
Merged

Update exception message in KubernetesClientConfiguration.InCluster.cs #844

merged 1 commit into from
Apr 27, 2022

Conversation

kentahikaru
Copy link
Contributor

Hello,
i propose updating this exception message as it is misleading. I spent several hours investigating why my container cannot see env variables when in fact it couldn't see service access token.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 27, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kentahikaru / name: kentahikaru (78f04fd)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 27, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @kentahikaru!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2022
@kentahikaru
Copy link
Contributor Author

/easycla

2 similar comments
@kentahikaru
Copy link
Contributor Author

/easycla

@kentahikaru
Copy link
Contributor Author

/easycla

@brendandburns
Copy link
Contributor

Thank you for the PR, looks like the CLA bot is still not happy, once that is fixed we can merge this.

@kentahikaru
Copy link
Contributor Author

Thank you for the PR, looks like the CLA bot is still not happy, once that is fixed we can merge this.

Hello, thanks for reply. Any advice how to confive bot about CLA ? I already got email fom LF.

@kentahikaru
Copy link
Contributor Author

/easycla

@tg123
Copy link
Member

tg123 commented Apr 27, 2022

seem your commit's author is different

@kentahikaru
Copy link
Contributor Author

/easycla

@tg123
Copy link
Member

tg123 commented Apr 27, 2022

/easycla

remove the old user and push -f

@kentahikaru
Copy link
Contributor Author

/easycla

remove the old user and push -f

sorry , can you be more specific ? what old user ? where ? on github or in my local git setings ?

@tg123
Copy link
Member

tg123 commented Apr 27, 2022

remove this commit or user
image

@kentahikaru kentahikaru force-pushed the update-exception-message branch from 20a4f94 to 78f04fd Compare April 27, 2022 19:51
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 27, 2022
@kentahikaru
Copy link
Contributor Author

remove this commit or user image

Thank you

@tg123
Copy link
Member

tg123 commented Apr 27, 2022

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kentahikaru, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit f0d15cb into kubernetes-client:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg123 tg123 tg123 approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@tg123 tg123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kentahikaru @k8s-ci-robot @brendandburns @tg123