Skip to content

fix watch=true doesn't respect cancellation token #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2020
Merged

fix watch=true doesn't respect cancellation token #376

merged 4 commits into from
Mar 23, 2020

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Mar 20, 2020

fix #375

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 20, 2020
brendandburns
brendandburns reviewed Mar 20, 2020
View reviewed changes
brendandburns
brendandburns reviewed Mar 20, 2020
View reviewed changes
brendandburns
brendandburns reviewed Mar 20, 2020
View reviewed changes
@brendandburns
Copy link
Contributor

Couple of small style comments.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2020
andykernahan
andykernahan reviewed Mar 22, 2020
View reviewed changes
@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit d55a333 into kubernetes-client:master Mar 23, 2020
@andykernahan andykernahan mentioned this pull request Mar 25, 2020
Closed
@tg123 tg123 deleted the fix_watch_cancel branch October 30, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns brendandburns left review comments

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

+1 more reviewer

@andykernahan andykernahan andykernahan left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ListNamespacedServiceWithHttpMessagesAsync with watch=true doesn't respect cancellation token with empty list
4 participants
@tg123 @brendandburns @k8s-ci-robot @andykernahan