Skip to content

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Sep 28, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 28, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 28, 2018
@brendandburns
Copy link
Contributor

Let's rev the major version of this library to reflect the new version of k8s?

Otherwise, LGTM.

@tg123
Copy link
Member Author

tg123 commented Oct 2, 2018

1.2.12 or something?

@itowlson
Copy link
Contributor

itowlson commented Oct 2, 2018

@tg123 It looks previous versions of the library haven't been coupled to the k8s version, which makes sense for when the library needs to be revved independently. Does this result in any breaking changes? If not, maybe 1.3.0?

@brendandburns
Copy link
Contributor

Yeah, I agree with @itowlson 1.3.0 or 2.0.0

For the java library we adopted a "new major version for each k8s release" approach, we haven't done that in csharp so far, but maybe we should start (in which case 2.0.0 would be the right version)

@tg123
Copy link
Member Author

tg123 commented Oct 3, 2018

bumped to 1.3

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit df33816 into kubernetes-client:master Oct 3, 2018
@tg123 tg123 deleted the 1.12 branch February 5, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants