Revert "Bump Microsoft.CodeAnalysis.CSharp from 4.2.0 to 4.3.0" #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…netes-client#993)" This reverts commit a763810.
k8s-ci-robot
added
cncf-cla: yes
|
/assign @tg123 |
|
/lgtm We need to expand our test coverage to handle this so we would have blocked this PR in the future. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, m3nax The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
why this is not captured by build? |
|
It seems a visual studio problem, tonight I'll do some tests to better understand the problem |
m3nax
deleted the
revert-993-dependabot/nuget/Microsoft.CodeAnalysis.CSharp-4.3.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #993
I'm unable to build the project in visual studio 2022 (tested with vs professional 17.3.3, 17.3.4, 17.4.0 Preview 1.0) , source generator is broken in main branch
There is an open issue in dotnet/roslyn repo: dotnet/roslyn#63919
Broken commit: a763810