Prevent UnobservedTaskException in LeaderElector

klesta490 · Vladimír Kleštinec · commit 20d0a81f10ab · 2023-10-02T13:22:13.000+02:00
diff --git a/src/KubernetesClient/LeaderElection/LeaderElector.cs b/src/KubernetesClient/LeaderElection/LeaderElector.cs
@@ -211,8 +211,11 @@ private async Task AcquireAsync(CancellationToken cancellationToken)
                         // wait RetryPeriod since acq return immediately
                         await Task.Delay(delay, cancellationToken).ConfigureAwait(false);
                     }
-
-                    // else timeout
+                    else
+                    {
+                        // else timeout
+                        _ = acq.ContinueWith(t => _ = t.Exception /* prevent UnobservedTaskException */, TaskContinuationOptions.OnlyOnFaulted);
+                    }
                 }
                 finally
                 {

Original file line number	Diff line number	Diff line change
`@@ -211,8 +211,11 @@ private async Task AcquireAsync(CancellationToken cancellationToken)`
`211`	`211`	`// wait RetryPeriod since acq return immediately`
`212`	`212`	`await Task.Delay(delay, cancellationToken).ConfigureAwait(false);`
`213`	`213`	`}`
`214`		`-`
`215`		`- // else timeout`
	`214`	`+ else`
	`215`	`+ {`
	`216`	`+ // else timeout`
	`217`	`+ _ = acq.ContinueWith(t => _ = t.Exception /* prevent UnobservedTaskException */, TaskContinuationOptions.OnlyOnFaulted);`
	`218`	`+ }`
`216`	`219`	`}`
`217`	`220`	`finally`
`218`	`221`	`{`