Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeflow Pipelines Volume examples #757

Closed
sarahmaddox opened this issue Jun 3, 2019 · 7 comments · Fixed by #1122
Closed

Kubeflow Pipelines Volume examples #757

sarahmaddox opened this issue Jun 3, 2019 · 7 comments · Fixed by #1122
Assignees

Comments

@sarahmaddox
Copy link
Contributor

The Kubeflow Pipelines DSL was recently extended to include PipelineVolume and PipelineVolumeSnapshot. These are an abstraction for the user to manipulate PVCs and VolumeSnapshots for data management purposes, also exposing dependencies according to their usage.

See PR kubeflow/pipelines#926 for further details.

We need and example and doc covering the above feature.

Thanks @dansanche for suggesting this doc!

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label improvement/enhancement to this issue, with a confidence of 0.82. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@sarahmaddox sarahmaddox added the doc-sprint Issues to work on during the Kubeflow Doc Sprint label Jun 3, 2019
@elikatsis
Copy link
Member

Hi there!
The initial design has changed after the review process.
For example, PipelineVolumeSnapshots don't exist. Also, the manipulation of any Kubernetes Resource is available via ResourceOp class.

The final implementation is closer to this design. The merged PR has just a few minor enhancements (it doesn't diverge from the logic described).

There are some examples under https://github.com/kubeflow/pipelines/tree/master/samples/resourceops.
However, I will be refactoring the directories of the samples to group the ones that aim to show PVC manipulation and those which refer to the VolumeSnapshots to make the navigation easier for the users.

I'll be happy to help with the documentation!

@sarahmaddox
Copy link
Contributor Author

Thanks @elikatsis! Would you like to take part in the doc sprint, to help create the docs? July 10-12. You can take part on site (Kirkland) or online.

Here's the Kanban board for the Kubeflow Doc Sprint.

Full details are on the doc sprint wiki.

Here's the signup form.

@elikatsis
Copy link
Member

@sarahmaddox, Hello Sarah !

Unfortunately, I couldn't make it for this doc sprint and I am really sorry I didn't mention it earlier.
I've already begun working on some basic documentation with the PR kubeflow/pipelines#1433 (I'll ping the PR thread to see what's need to be done to get it merged).

I believe I will be able to contribute to the documentation within the next few weeks!

@sarahmaddox
Copy link
Contributor Author

/assign @elikatsis

Thanks @elikatsis it's great to know that you'll be able to tackle the docs. No worries that it won't be within the timeframe of the doc sprint.

@sarahmaddox sarahmaddox removed the doc-sprint Issues to work on during the Kubeflow Doc Sprint label Jul 12, 2019
@elikatsis
Copy link
Member

Hello!

Right now we've got #837 merged (link to the official website) and there are also several examples in kubeflow/pipelines repo:

There are some READMEs, too (1, 2).

I think all of the above close this issue.

@sarahmaddox, Sarah, what's your opinion? Is there anything else you think we should do?

@sarahmaddox
Copy link
Contributor Author

Thanks @elikatsis! The information is a little scattered at the moment. We have:

It'd be good to have an overview of the features on the website, in a page under this section: https://www.kubeflow.org/docs/pipelines/sdk/
The overview should explain what the features allow users to do, and link to the samples for indepth usage info.

Preferably the info in the READMEs should move to the website, as they contain user-focused info rather than developer-focused info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants