-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use conditions instead of phase #223
Comments
I think so 🤔 We could design the correspondence between phase and conditions first and the implementation may be blocked until #215 merged. |
Agree with @gaocegege. A slight question here: what's the design purpose of ReplicaStatuses and ReplicasStates here? |
ReplicaStatuses and ReplicaStates provide information about each replica. Not all replicas might be in the same state; some might be crashing for example. So ReplicaStatuses provide finer grained information then just the overall status of the job. |
I think we could close the issue since v1alpha2 already implemented it. |
https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#typical-status-properties
kubernetes suggests us to use conditions instead of phase, now the code uses phase heavily, I think we should have a plan to deprecate phase.
/cc @DjangoPeng
label/enhancement
The text was updated successfully, but these errors were encountered: