Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spark 3.5.3 #2202

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Conversation

jacobsalway
Copy link
Member

@jacobsalway jacobsalway commented Sep 29, 2024

Purpose of this PR

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

@jacobsalway
Copy link
Member Author

/hold

The official spark:3.5.3 image hasn't been published yet

https://github.com/apache/spark-docker?tab=readme-ov-file#step-3-publish-spark-docker-official-images

Copy link
Member Author

@jacobsalway jacobsalway Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update this table during the release process depending on whether this upgrade lands in a minor or patch version.

Signed-off-by: Jacob Salway <jacob.salway@gmail.com>
Signed-off-by: Jacob Salway <jacob.salway@gmail.com>
@jacobsalway jacobsalway marked this pull request as ready for review October 13, 2024 00:16
@jacobsalway
Copy link
Member Author

/assign @ChenYi015 @ImpSy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci-lint was failing on the errcheck linter because of this.

Copy link
Contributor

@ImpSy ImpSy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 13, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, ImpSy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Contributor

Will merge this PR for image spark:3.5.3 has already been released.
/unhold

@google-oss-prow google-oss-prow bot merged commit 718e244 into kubeflow:master Oct 13, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants