Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @ChenYi015 to approvers #2096

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

ChenYi015
Copy link
Contributor

Purpose of this PR

Add myself to Spark operator approvers so I can approve and merge PRs.

Contributed PRs: https://github.com/kubeflow/spark-operator/pulls?q=is%3Apr+author%3AChenYi015

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015
Copy link
Contributor Author

/assign @yuchaoran2011 @vara-bonthu @andreyvelich

Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Well deserved and welcome!

@google-oss-prow google-oss-prow bot added the lgtm label Jul 24, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b27717d into kubeflow:master Jul 24, 2024
7 checks passed
@andreyvelich
Copy link
Member

Thank you for your substantial contribution to the Spark Operator project @ChenYi015 🎉
/lgtm

@ChenYi015 ChenYi015 deleted the owners branch July 25, 2024 02:04
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 26, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
YanivKunda pushed a commit to YanivKunda/spark-operator that referenced this pull request Aug 5, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants