Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .gitlab-ci.yml #2069

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Conversation

jacobsalway
Copy link
Member

🛑 Important:

Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!

For guidelines on how to contribute, please review the CONTRIBUTING.md document.

Purpose of this PR

The repo is hosted on Github and uses Github Actions for the build and release process

Proposed changes:

  • Remove .gitlab-ci.yml from the repo

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Signed-off-by: Jacob Salway <jacob.salway@rokt.com>
@jacobsalway jacobsalway marked this pull request as ready for review June 20, 2024 12:11
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacobsalway .

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 012b52a into kubeflow:master Jun 22, 2024
7 checks passed
YanivKunda pushed a commit to YanivKunda/spark-operator that referenced this pull request Jul 4, 2024
Signed-off-by: Jacob Salway <jacob.salway@rokt.com>
Signed-off-by: Yaniv Kunda <ykunda@akamai.com>
jacobsalway added a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024
Signed-off-by: Jacob Salway <jacob.salway@rokt.com>
@jacobsalway jacobsalway deleted the remove-gitlab-ci branch August 1, 2024 12:36
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
Signed-off-by: Jacob Salway <jacob.salway@rokt.com>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
Signed-off-by: Jacob Salway <jacob.salway@rokt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants