Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgraded k8s deps #1983

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: upgraded k8s deps #1983

merged 1 commit into from
Apr 16, 2024

Conversation

AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Apr 16, 2024 •
edited
Loading

upgraded k8s deps after #1968
fixed docs generation

yuchaoran2011
yuchaoran2011 reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewChubatiuk Please follow the PR template to include more details in the PR description. Specifically, why is the PR needed and what's the impact (e.g. it's needed to make operator run on k8s version x and it will drop support for k8s version y)

@AndrewChubatiuk
Copy link
Contributor Author

@yuchaoran2011 after recent change in master upgraded depdendencies to fix CI pipeline also it decreases binary size

@AndrewChubatiuk
fix: upgraded k8s and volcano deps
6d51149 
Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com>
yuchaoran2011
yuchaoran2011 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 16, 2024
@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewChubatiuk, yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e9dbdfb into kubeflow:master Apr 16, 2024
7 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the upgrade-k8s-deps branch April 16, 2024 20:35
@YanivKunda YanivKunda mentioned this pull request May 21, 2024
Closed
1 task
@Aakcht Aakcht mentioned this pull request May 31, 2024
Merged
8 tasks
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
@AndrewChubatiuk @sigmarkarl
fix: upgraded k8s deps (kubeflow#1983)
1c2b2c3 
Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
@AndrewChubatiuk
fix: upgraded k8s deps (kubeflow#1983)
d08378d 
Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuchaoran2011 yuchaoran2011 yuchaoran2011 approved these changes

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

Assignees

@yuchaoran2011 yuchaoran2011

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewChubatiuk @yuchaoran2011