-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed docker image tag and updated chart docs #1969
fixed docker image tag and updated chart docs #1969
Conversation
Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com>
2d88160
to
468dfd4
Compare
@AndrewChubatiuk , it looks like the PR description is missing. Could you please provide more details to help us review your changes effectively? Purpose of the Change: Why is this change necessary? Thank you for contributing, and we look forward to your detailed response! |
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewChubatiuk, vara-bonthu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com>
Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com> Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com>
* Issue templates are added to the repo Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * removed Google CLA requirement Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Updated ghcr.io registry references in the workflow Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Added Pull request template Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Updated Main README.md with Kubeflow header and new Slack channel link Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Removed the License header and it will be replaced with Kubeflow guidelines Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Revert "Removed the License header and it will be replaced with Kubeflow guidelines" This reverts commit b892f5c. Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Readme line revert for gcp docs Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * pre-commit run -a updates Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * fixed the helm lint issue by upgrading the Helm chart version Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * fixed docker image tag and updated chart docs (#1969) Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com> Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * rebase from master Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> --------- Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com> Co-authored-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com> Signed-off-by: Peter McClonski <mcclonski_peter@bah.com>
* Issue templates are added to the repo Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * removed Google CLA requirement Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Updated ghcr.io registry references in the workflow Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Added Pull request template Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Updated Main README.md with Kubeflow header and new Slack channel link Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Removed the License header and it will be replaced with Kubeflow guidelines Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Revert "Removed the License header and it will be replaced with Kubeflow guidelines" This reverts commit b892f5c. Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Readme line revert for gcp docs Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * pre-commit run -a updates Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * fixed the helm lint issue by upgrading the Helm chart version Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * fixed docker image tag and updated chart docs (kubeflow#1969) Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com> Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * rebase from master Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> --------- Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com> Co-authored-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com> Signed-off-by: Peter McClonski <mcclonski_peter@bah.com>
Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com>
* Issue templates are added to the repo Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * removed Google CLA requirement Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Updated ghcr.io registry references in the workflow Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Added Pull request template Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Updated Main README.md with Kubeflow header and new Slack channel link Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Removed the License header and it will be replaced with Kubeflow guidelines Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Revert "Removed the License header and it will be replaced with Kubeflow guidelines" This reverts commit b892f5c. Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Readme line revert for gcp docs Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * pre-commit run -a updates Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * fixed the helm lint issue by upgrading the Helm chart version Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * fixed docker image tag and updated chart docs (kubeflow#1969) Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com> Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * rebase from master Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> --------- Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com> Co-authored-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com>
* Issue templates are added to the repo Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * removed Google CLA requirement Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Updated ghcr.io registry references in the workflow Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Added Pull request template Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Updated Main README.md with Kubeflow header and new Slack channel link Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Removed the License header and it will be replaced with Kubeflow guidelines Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Revert "Removed the License header and it will be replaced with Kubeflow guidelines" This reverts commit b892f5c. Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * Readme line revert for gcp docs Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * pre-commit run -a updates Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * fixed the helm lint issue by upgrading the Helm chart version Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * fixed docker image tag and updated chart docs (kubeflow#1969) Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com> Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> * rebase from master Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> --------- Signed-off-by: Vara Bonthu <vara.bonthu@gmail.com> Signed-off-by: Andrew Chubatiuk <andrew.chubatiuk@gmail.com> Co-authored-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
now docker images are published with 'preview' tag. changed it to a app version from Chart.yaml