Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid API resources in discovery #1758

Merged

Conversation

wiltonsr
Copy link
Contributor

@wiltonsr wiltonsr commented May 22, 2023

Solution based in a similar issue fixed in helm: helm/helm#6361

To reproduce the problem, just deploy an apiservice

$ oc apply -f https://raw.githubusercontent.com/kubernetes/sample-apiserver/master/artifacts/example/apiservice.yaml

This gonna create an error in your cluster

$ oc api-resources > /dev/null
error: unable to retrieve the complete list of server APIs: wardle.example.com/v1alpha1: the server is currently unable to handle the request

After this, the Spark Operator pod will stop with the same error above.

This PR prevents this using the IsGroupDiscoveryFailedError method.

@google-cla
Copy link

google-cla bot commented May 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@liyinan926 liyinan926 merged commit cd78251 into kubeflow:master Oct 27, 2023
peter-mcclonski pushed a commit to TechnologyBrewery/spark-on-k8s-operator that referenced this pull request Apr 16, 2024
Signed-off-by: Peter McClonski <mcclonski_peter@bah.com>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants