Ensure that driver is deleted prior to sparkapplication resubmission #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
…ubeflow#1521) * Ensure that driver is deleted prior to sparkapplication resubmission Signed-off-by: Khor Shu Heng <khor.heng@gojek.com> * Update app version Signed-off-by: Khor Shu Heng <khor.heng@gojek.com> * Update chart version Signed-off-by: Khor Shu Heng <khor.heng@gojek.com> Co-authored-by: Khor Shu Heng <khor.heng@gojek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under rare circumstances, a Spark driver pod could have been created despite the fact that spark submission attempt failed. The driver pod might not necessarily be running, it could be stuck in Pending state due to failure of creating the associated configmap, for example. In such situation, the current Spark operator would not attempt to resubmit the job, nor would the submission count attempt increase. As a result, the sparkapplication will be stuck in the submission failure state indefinitely.
This MR deletes the associated spark resource in case such situation arise, which will allow the spark operator to resubmit the job again.