implement shareProcessNamespace in SparkPodSpec #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyinan926
approved these changes
May 19, 2021
|
Looks like you also need to update the API doc following instruction in https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/master/docs/developer-guide.md#build-the-api-specification-doc, and also update the CRD definitions under |
ImpSy
force-pushed
the
shareProcessNamespace
branch
from
e9df068 to
d38c1a5
Compare
|
@liyinan926 is this ok to merge for you ? |
liyinan926
reviewed
May 20, 2021
manifest/crds/sparkoperator.k8s.io_scheduledsparkapplications.yaml
Outdated
Show resolved
Hide resolved
|
I've fixup the issues, anything else before merging ? |
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
* implement shareProcessNamespace in SparkPodSpec * fixup! implement shareProcessNamespace in SparkPodSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR implement
shareProcessNamespaceinSparkPodSpecDon't hesitate to tell me if i need to change anything