Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Common label changes with K8s upgrade to 1.12.3 #204

Merged
merged 6 commits into from
Aug 12, 2019

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Aug 11, 2019

This PR tracks

  1. Update k8s libs to 1.12.3(Update k8s libraries to 1.12.3 training-operator#1054)
  2. Updates labels to common type (Renaming labels to common types training-operator#1064)

@johnugeorge johnugeorge changed the title K8s upgrade to 1.12.3 Common label changes with K8s upgrade to 1.12.3 Aug 11, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.281% when pulling 31a52dd on johnugeorge:k8supgrade into 9a6ae63 on kubeflow:master.

@johnugeorge
Copy link
Member Author

/retest

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

@gaocegege
Copy link
Member

/test kubeflow-pytorch-operator-presubmit

@johnugeorge
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants