Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify informers namespace in persistence agent #901

Merged
merged 3 commits into from
May 6, 2019
Merged

Allow to specify informers namespace in persistence agent #901

merged 3 commits into from
May 6, 2019

Conversation

ywskycn
Copy link
Member

@ywskycn ywskycn commented Mar 4, 2019 •
edited by jlewi
Loading

Need to do the same in persistence agent. The diff uses "informerNamespace" as the variable, as the "namespace" has been taken. Once we reach an agreement on #867, we can change to namespace. Let's get #867 merged first.

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @ywskycn. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

Hi @ywskycn. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywskycn ywskycn mentioned this pull request Mar 5, 2019
Merged
@IronPan
Copy link
Member

IronPan commented Apr 24, 2019

/ok-to-test

@IronPan
Copy link
Member

IronPan commented Apr 24, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ywskycn
Copy link
Member Author

ywskycn commented Apr 26, 2019

@IronPan mind taking another pass? Just renamed the variable.

@ywskycn
Copy link
Member Author

ywskycn commented May 1, 2019

/assign @IronPan

@vicaire
Copy link
Contributor

vicaire commented May 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 2b5eb35 into kubeflow:master May 6, 2019
@Duske Duske mentioned this pull request Jun 10, 2019
Closed
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@theofpa
Kaniko cache (kubeflow#901)
c4e335d 
* add caching in kaniko task

Signed-off-by: Theofilos Papapanagiotou <theofilos@gmail.com>

* add caching in kaniko task

Signed-off-by: Theofilos Papapanagiotou <theofilos@gmail.com>

* add remote repo for kaniko cache

Signed-off-by: Theofilos Papapanagiotou <theofilos@gmail.com>

* define a redo snapshotMode to speed up the filesystem parsing by 50%

Signed-off-by: Theofilos Papapanagiotou <theofilos@gmail.com>

* add result from dry-run

Signed-off-by: Theofilos Papapanagiotou <theofilos@gmail.com>
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Fix kustomize config to conform to kubebuilder v2 layout (kubeflow#901)
a23c3dc 
* Refactor kustomize config directory

* Fix image patch

* Move status patch to default

* Add namespace selector

* Remove crd status patch
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@yhwang
feat(sdk): extension function Loop.enumerate() (kubeflow#901)
53fa9e7 
* feat(SDK): extension function `Loop.enumerate()`

Add helper function: `enumerate()` in Loop to
return indices and item. It could be used to get
current iteration number and item value.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

* add logic to handle nested loop

Add logic to handle nested loop and test cases

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@IronPan IronPan

@vicaire vicaire

Labels
approved lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywskycn @k8s-ci-robot @IronPan @vicaire