Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve runtime graph starting and running experience #734

Merged
merged 6 commits into from
Jan 30, 2019
Merged

Improve runtime graph starting and running experience #734

merged 6 commits into from
Jan 30, 2019

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Jan 25, 2019 •
edited
Loading

  • displays spinner when no nodes have started
  • adds info message to bottom of runtime graph indicating that it is
    runtime and that the graph will update over time
  • adds placeholder nodes at end of graph to indicate future progress

Example graph for unfinished run:
image

This change is Reviewable

@rileyjbauer
Improve runtime graph starting and running experience
5ee8e7a 
- displays spinner when no nodes have started
- adds info message to bottom of runtime graph indicating that it is
runtime and that the graph will update over time
- adds placeholder nodes at end of graph to indicate future progress
yebrahim
yebrahim reviewed Jan 26, 2019
View reviewed changes
Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor comments.

frontend/src/pages/RunDetails.tsx Outdated Show resolved Hide resolved
frontend/src/pages/RunDetails.tsx Outdated Show resolved Hide resolved
frontend/src/lib/WorkflowParser.tsx Outdated Show resolved Hide resolved
frontend/src/components/Graph.tsx Show resolved Hide resolved
@ajayalfred
Copy link
Contributor

LG. Can you update the size of the 3-dot icon to 24px? And color for both the dotted line and icon is #9AA0A6.

image

@rileyjbauer
Copy link
Contributor Author

@ajayalfred, I've modified it as you indicated

@rileyjbauer rileyjbauer changed the title [WIP] Improve runtime graph starting and running experience Improve runtime graph starting and running experience Jan 28, 2019
@rileyjbauer
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@yebrahim
Copy link
Contributor

Can we add some tests to cover the new experience?

@ajayalfred
Copy link
Contributor

@ajayalfred, I've modified it as you indicated

Thanks Riley!

@rileyjbauer
Copy link
Contributor Author

@yebrahim, moved the icon+tooltip to its own atom and added tests. PTAL

yebrahim
yebrahim reviewed Jan 30, 2019
View reviewed changes
frontend/src/atoms/IconWithTooltip.test.tsx Outdated Show resolved Hide resolved
frontend/src/lib/WorkflowParser.test.ts Show resolved Hide resolved
frontend/src/pages/RunDetails.test.tsx Outdated Show resolved Hide resolved
frontend/src/pages/RunDetails.test.tsx Outdated Show resolved Hide resolved
yebrahim
yebrahim approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
/lgtm

@rileyjbauer
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@rileyjbauer
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2c6ad29 into kubeflow:master Jan 30, 2019
@rileyjbauer rileyjbauer deleted the run-graph-pending-states branch May 6, 2019 22:17
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@pingsutw
Update README.md (kubeflow#734)
810a879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebrahim yebrahim yebrahim approved these changes

@qimingj qimingj Awaiting requested review from qimingj

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@yebrahim yebrahim

@ajayalfred ajayalfred

Labels
approved area/frontend lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rileyjbauer @ajayalfred @yebrahim @k8s-ci-robot