Use linguist annotations to skip diffing generated files #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
…ubeflow#652) * Create a simple script to deploy Kubeflow using the GCP blueprint. This is basically just a wrapper around make commands. * This is the first step in setting up auto deployments of the GCP blueprint for CI purposes. * Fix some bugs in the management cluster that popped up while testing the blueprint * Fix CNRM install for the kubeflow-ci-deployment namespace. CNRM wasn't properly configured to administer that namespace. The appropriate role bindings weren't being created in the correct namespaces and the statefulset was using the host project and not the managed project. * See kubeflow#644 for reference on the management cluster settup * We should use the kubeflow-testing@kubeflow-ci service account and not a service account owned by project kubeflow-ci-deployment as the latter is being GC'd by our cleanup ci scripts which breaks the management cluster. * Also per kubeflow#644 permissions are now set at the folder level to prevent the permissions from being GC'd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/github/linguist#overrides
/assign @IronPan
/assign @neuromage
This change is