Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up the sdk version to 0.1.4 #522

Merged
merged 4 commits into from
Dec 15, 2018
Merged

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Dec 12, 2018

Fix #520

The current nodebook sample uses gcp module which is only available since 0.1.4.


This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 13, 2018

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 13, 2018

/approve

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 13, 2018

Please update other notebooks as well.

@gaoning777
Copy link
Contributor

Can we update the component image tags too? I commented with #TODO-release: update the release tag for the next release\n" wherever we need to update a new release. You can search for TODO-release.
If you think it might be another PR, fine by me.

@gaoning777
Copy link
Contributor

/lgtm

@hongye-sun
Copy link
Contributor Author

/assign IronPan

@hongye-sun
Copy link
Contributor Author

/assign qimingj

@IronPan
Copy link
Member

IronPan commented Dec 15, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e356adf into kubeflow:master Dec 15, 2018
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Kubeflow autodeploy jobs need to use kubeflow/kfctl

* Related to kubeflow/kfctl#7

* Cleanup

* Use PR for manual testing.

* Unpin

* Fix lint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants