fix(components): Update components/local/base/Dockerfile to use Python3 #5047
Conversation
| RUN pip install --no-cache-dir pandas==0.24.2 | ||
| RUN pip install --no-cache-dir scikit-learn==0.21.2 | ||
| RUN pip install --no-cache-dir scipy==1.4.1 | ||
| RUN pip install --no-cache-dir tensorflow==2.2.0 | ||
|
|
There was a problem hiding this comment.
I picked the same versions as found in [1], so that they're known to be compatible with each other.
|
|
||
| ADD build /ml | ||
|
|
||
| ENV PATH $PATH:/tools/node/bin:/tools/google-cloud-sdk/bin |
There was a problem hiding this comment.
Just to be sure, gcloud is not used in these components, right?
There was a problem hiding this comment.
Right, I checked the code under these locations:
- https://github.com/kubeflow/pipelines/tree/master/components/local/confusion_matrix
- https://github.com/kubeflow/pipelines/tree/master/components/local/roc
Didn't see any usage of cloud sdk binary.
And I didn't see any usage of google-api-python-client as well, thus removed RUN pip install google-api-python-client==1.6.2
|
/lgtm Thanks Chen! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun, numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun, numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold Thanks for review, Jiaxiao. Submitting. |
Description of your changes:
Components don't build due to Python2.7 being used: https://pantheon.corp.google.com/cloud-build/builds/b34906af-0485-43be-b994-3fdfab6a0f6b;step=29?project=ml-pipeline-test
Related to #5007
Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.