Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/GCP - Replaced default_gcp_op with task.apply(use_gcp_secret) #430

Merged
merged 1 commit into from
Dec 4, 2018
Merged

SDK/GCP - Replaced default_gcp_op with task.apply(use_gcp_secret) #430

merged 1 commit into from
Dec 4, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 30, 2018 •
edited
Loading

This change makes it possible to us GCP secret without needing to inherit from a different op.
It also allows users to chain "external" mods that configure tasks:

Example:
  from kfp.gcp import use_gcp_secret
  task = (
    train_op(...)
      .set_memory_request('1GB')
      .apply(use_gcp_secret('user-gcp-sa'))
      .set_memory_limit('2GB')
  )

This change is Reviewable

@Ark-kun Ark-kun force-pushed the avolkov/SDK/GCP---Replaced-default_gcp_op-with-task.apply(use_gcp_secret) branch from 92f2da9 to e17ac92 Compare November 30, 2018 21:22
@Ark-kun Ark-kun force-pushed the avolkov/SDK/GCP---Replaced-default_gcp_op-with-task.apply(use_gcp_secret) branch from e17ac92 to 2d7854a Compare November 30, 2018 21:33
IronPan
IronPan reviewed Nov 30, 2018
View reviewed changes
Copy link
Member

@IronPan IronPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member

IronPan commented Nov 30, 2018

This is great! Thanks Alexey

@IronPan
Copy link
Member

IronPan commented Dec 3, 2018

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 3, 2018

/test presubmit-e2e-test

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 4, 2018

/test presubmit-e2e-test

@IronPan
Copy link
Member

IronPan commented Dec 4, 2018

/test presubmit-e2e-test

@IronPan
Copy link
Member

IronPan commented Dec 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 800bd02 into master Dec 4, 2018
@Ark-kun Ark-kun deleted the avolkov/SDK/GCP---Replaced-default_gcp_op-with-task.apply(use_gcp_secret) branch December 4, 2018 02:02
@Ark-kun Ark-kun mentioned this pull request Dec 18, 2018
Closed
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@richardsliu @k8s-ci-robot
Fix periodic tests checkout script (kubeflow#430)
52615d4
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun @k8s-ci-robot
Get namespace from admission request in pod mutator (kubeflow#430)
4dbc635 
* Set pod namespace from SERVING_NAMESPACE env

* Get namespace from admission request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan IronPan left review comments

@qimingj qimingj qimingj left review comments

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@IronPan IronPan

Labels
approved area/sdk lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @k8s-ci-robot @IronPan @qimingj