Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): gcp - add service account to deployments that need workload identity. Fixes #4183 #4188

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jul 9, 2020

Description of your changes:
Fixes #4183

These deployments need GCP permissions and we recommend workload identity. So each of them should have their own service account.

Checklist:

  • The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

    PR titles examples:

    • fix(frontend): fixes empty page. Fixes #1234
      Use fix to indicate that this PR fixes a bug.
    • feat(backend): configurable service account. Fixes #1234, fixes #1235
      Use feat to indicate that this PR adds a new feature.
    • chore: set up changelog generation tools
      Use chore to indicate that this PR makes some changes that users don't need to know.
    • test: fix CI failure. Part of #1234
      Use part of to indicate that a PR is working on an issue, but shouldn't close the issue when merged.
  • Do you want this pull request (PR) cherry-picked into the current release branch?

    If yes, use one of the following options:

    • (Recommended.) Ask the PR approver to add the cherrypick-approved label to this PR. The release manager adds this PR to the release branch in a batch update.
    • After this PR is merged, create a cherry-pick PR to add these changes to the release branch. (For more information about creating a cherry-pick PR, see the Kubeflow Pipelines release guide.)

…nd cloudsql proxy deployments for workload identity
@Bobgy Bobgy added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Jul 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bobgy
You can assign the PR to them by writing /assign @bobgy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeflow-bot
Copy link

This change is Reviewable

@Bobgy Bobgy merged commit c5c9739 into kubeflow:master Jul 9, 2020
@Bobgy Bobgy deleted the add_ksa_to_cloudsql_and_minio_dep branch July 9, 2020 10:24
@Bobgy Bobgy added the cherrypicked cherry picked to release branch `release-x.y` label Jul 9, 2020
Bobgy added a commit that referenced this pull request Jul 9, 2020
…nd cloudsql proxy deployments for workload identity (#4188)
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
…nd cloudsql proxy deployments for workload identity (kubeflow#4188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minio GCS Gateway cannnot autheticate in a GKE Cluster
4 participants