[Frontend] Migrate to create-react-app #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bobgy
changed the title
|
/retest |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, jingzhang36 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @jingzhang36 |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Updated create-react-app dependencies * Fix some type errors * Fix type errors * Fix linting and typing * Fix more things * Fix typestyle mock * Fix some unit tests * Update snapshots * Frontend server should use its own configuration * Clean up server tsconfig.json and tslint.json * Fix mock-backend * Frontend image cloudbuild config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2432
/area frontend
/area engprod
The change is huge, so I will try to get this in ASAP to avoid complex merge conflicts. Currently there aren't many UI changes, so I will merge this after I tested the image.
Verification
Built and tested the image gcr.io/gongyuan-pipeline-test/dev/frontend@sha256:49e51ef0485546caed638a4a506a166990f004ae454d5fea25c645e44c6443d9. I didn't see any differences.
built bundle size:
There is a minor decrease, but there are more bundles.
This change is