Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add link to allow user easily report issue #3030

Merged
merged 4 commits into from
Feb 12, 2020
Merged

add link to allow user easily report issue #3030

merged 4 commits into from
Feb 12, 2020

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Feb 10, 2020 •
edited by jlewi
Loading

This change is Reviewable

@rmgogogo
Copy link
Contributor Author

#3024

@Bobgy
Copy link
Contributor

Bobgy commented Feb 10, 2020

Fixes #3024

@Bobgy
Copy link
Contributor

Bobgy commented Feb 10, 2020

and take a look at https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/3030/kubeflow-pipeline-frontend-test/1226809426036396035#1:build-log.txt%3A83

@Bobgy
Copy link
Contributor

Bobgy commented Feb 12, 2020

FYI, you need to merge master to pass travis tests: #3035

@rmgogogo
Copy link
Contributor Author

and take a look at https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/3030/kubeflow-pipeline-frontend-test/1226809426036396035#1:build-log.txt%3A83

not sure whether you also config the style or because didn't change the file. I configured the Prettier and it has more changes than I expected.

@rmgogogo
Copy link
Contributor Author

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Feb 12, 2020

@rmgogogo It seems you also enabled vscode organize imports feature. We haven't enforced organize imports, so you are seeing more changes. No worry, these changes are good.

Note frontend tests are still failing because some snapshots need to be updated, you can do so by
npm test -- -u and run all tests.
https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_pipelines/3030/kubeflow-pipeline-frontend-test/1227486969991270400#1:build-log.txt%3A1838

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 10293ac into kubeflow:master Feb 12, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@rmgogogo @Jeffwan
add link to allow user easily report issue (kubeflow#3030)
b57d156 
* done

* done

* done

Co-authored-by: renmingu <40223865+renmingu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Bobgy left review comments

@IronPan IronPan Awaiting requested review from IronPan

Assignees
No one assigned
Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmgogogo @Bobgy @k8s-ci-robot