Update deployer base to 0.1.40 #2696
Conversation
| @@ -35,15 +35,6 @@ function run-proxy-agent { | |||
| --health-check-unhealthy-threshold=${HEALTH_CHECK_UNHEALTHY_THRESHOLD} | |||
| } | |||
|
|
|||
| # Check if the cluster already have proxy agent installed by checking ConfigMap. | |||
| if kubectl get configmap inverse-proxy-config; then | |||
There was a problem hiding this comment.
Removing this check will result in URL change if the proxy pod is restarted for any reason.
I think what you could do instead is check whether BACKEND_ID/PROXY_URL is empty or not.
There was a problem hiding this comment.
this PR is based on #2391
Please review that one first.
In this PR, it only change the deployer Dockerfile.
I will remove the [WIP] from the title after PR2391 got merged.
There was a problem hiding this comment.
By the way, to your question of changed URL, it won't. it uses VM_ID as part of key to query/create the URL. Let's continue the comments in #2391.
manifests/gcp_marketplace/chart/kubeflow-pipelines/templates/proxy.yaml
Outdated
Show resolved
Hide resolved
| FROM gcr.io/cloud-marketplace-tools/k8s/deployer_helm/onbuild:latest |
There was a problem hiding this comment.
Once you figured out a image that works, could you ping the image version instead of using latest?
There was a problem hiding this comment.
I'm following the guide to setup better release process.
For each release, we will rebuild Deployer, put to QA, use corresponding latest verify tool etc.
I will add Erika to review after #2391. Feel free to ignore this PR for now.
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmgogogo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add label and namespace to resource created inside pod * fix * done * update existing configmap for better GC * update dependency to make sure configmap got created before run script * self fix * use latest deployer base * deployer * all done * upgrade deployer to 0.1.37 for bug bash * all done * done * fix issue for MLMD * done * done Co-authored-by: renmingu <40223865+renmingu@users.noreply.github.com>
* add label and namespace to resource created inside pod * fix * done * update existing configmap for better GC * update dependency to make sure configmap got created before run script * self fix * use latest deployer base * deployer * all done * upgrade deployer to 0.1.37 for bug bash * all done * done * fix issue for MLMD * done * done Co-authored-by: renmingu <40223865+renmingu@users.noreply.github.com>
WIP. cluster level is still not well GCed.
Change deployer to latest base.
This change is