-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2682: Support a custom kube config location in K8sJobHelper #2683
Conversation
Hi @pahask8. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Ark-kun please take a look. |
/ok-to-test |
@Ark-kun , @gaoning777 , could you please take a look? Thank you |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Hi @Ark-kun, is master broken? Tests failed:
Thank you |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
/test kubeflow-pipeline-e2e-test |
1 similar comment
/test kubeflow-pipeline-e2e-test |
Hi @Ark-kun, my pull request is still failing with e2e tests even when I've rebased with the master:
Thank you |
The actual error is:
|
/retest |
Thank you, looks like it passed now. |
Fixes #2682
This change is