Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clusterrole for pipeline-runner with seldondeployments #2458

Merged
merged 1 commit into from
Oct 25, 2019
Merged

clusterrole for pipeline-runner with seldondeployments #2458

merged 1 commit into from
Oct 25, 2019

Conversation

MingfeiPan
Copy link
Contributor

@MingfeiPan MingfeiPan commented Oct 22, 2019 •
edited
Loading

Considering with the issue 2455

Since now Seldon is a default component in kubeflow toolkits, it would be nice if we add seldondeployment clusterrole for pipeline-runner when initializing.

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @MingfeiPan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MingfeiPan
Copy link
Contributor Author

/assign @IronPan

@IronPan
Copy link
Member

IronPan commented Oct 25, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0b8d2e1 into kubeflow:master Oct 25, 2019
@MingfeiPan MingfeiPan mentioned this pull request Oct 25, 2019
Closed
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@tenzen-y
Regenerate the Go client by code-generator (kubeflow#2458)
55cb163 
* Regenerate the Go client

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>

* Generate the Go client for v1alpha1 API

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>

* Update the violation exeptions list

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@IronPan IronPan

Labels
approved lgtm needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MingfeiPan @k8s-ci-robot @IronPan