Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloud-platform scope in the test to reclaim the ai platform sample models #2355

Merged
merged 3 commits into from
Oct 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions samples/contrib/parameterized_tfx_oss/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Finally, run `python setup.py install` from `tfx/tfx`. After that, running
`chicago_taxi_pipeline_simple.py` compiles the TFX pipeline into KFP pipeline package.
This pipeline requires google storage permission to run.


## Caveats

This sample uses pipeline parameters in a TFX pipeline, which is not yet fully supported.
Expand Down
18 changes: 17 additions & 1 deletion samples/core/ai_platform/ai_platform.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,23 @@
"metadata": {},
"outputs": [],
"source": [
"kfp.Client().create_run_from_pipeline_func(pipeline, arguments={}, experiment_name=experiment_name)"
"pipeline = kfp.Client().create_run_from_pipeline_func(pipeline, arguments={}, experiment_name=experiment_name)"
]
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"### Wait for the pipeline to finish"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"pipeline.wait_for_run_completion(timeout=1800)"
]
},
{
Expand Down
1 change: 1 addition & 0 deletions samples/core/xgboost_training_cm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ or not.

Preprocessing uses Google Cloud DataProc. Therefore, you must enable the [DataProc API](https://cloud.google.com/endpoints/docs/openapi/enable-api) for the given GCP project.


## Compile

Follow the guide to [building a pipeline](https://www.kubeflow.org/docs/guides/pipelines/build-pipeline/) to install the Kubeflow Pipelines SDK and compile the sample Python into a workflow specification. The specification takes the form of a YAML file compressed into a `.zip` file.
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kfp/_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ def __init__(self, client, run_info):

def wait_for_run_completion(self, timeout=None):
timeout = timeout or datetime.datetime.max - datetime.datetime.min
return self._client.wait_for_run_completion(timeout)
return self._client.wait_for_run_completion(self.run_id, timeout)
gaoning777 marked this conversation as resolved.
Show resolved Hide resolved

def __str__(self):
return '<RunPipelineResult(run_id={})>'.format(self.run_id)
Expand Down
2 changes: 1 addition & 1 deletion test/deploy-cluster.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ else
SHOULD_CLEANUP_CLUSTER=true
# "storage-rw" is needed to allow VMs to push to gcr.io
# reference: https://cloud.google.com/compute/docs/access/service-accounts#accesscopesiam
SCOPE_ARG="--scopes=storage-rw"
SCOPE_ARG="--scopes=storage-rw,cloud-platform"
gaoning777 marked this conversation as resolved.
Show resolved Hide resolved
# Machine type and cluster size is the same as kubeflow deployment to
# easily compare performance. We can reduce usage later.
NODE_POOL_CONFIG_ARG="--num-nodes=2 --machine-type=n1-standard-8 \
Expand Down